Re: [vmw_vmci RFC 01/11] Apply VMCI context code

From: Greg KH
Date: Tue May 15 2012 - 19:47:44 EST


On Tue, May 15, 2012 at 08:06:58AM -0700, Andrew Stiegmann (stieg) wrote:
> +/*
> + *----------------------------------------------------------------------
> + *
> + * ctx_signal_notify --
> + *
> + * Sets the notify flag to true. Assumes that the context lock is
> + * held.
> + *
> + * Results:
> + * None.
> + *
> + * Side effects:
> + * None.
> + *
> + *----------------------------------------------------------------------
> + */
> +
> +static void ctx_signal_notify(struct vmci_ctx *context)
> +{
> + if (context->notify)
> + *context->notify = true;
> +}

What's with the bizarre comment block format here and throughout the
code? Care to fix it up (i.e. delete it all from static functions, and
use kerneldoc for public functions.)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/