Re: [vmw_vmci RFC 01/11] Apply VMCI context code

[Andrew Stiegmann]

Both of your comments have been added to my "to do" list before the next time I publish.  Thanks for the feedback.

----- Original Message -----
> From: "Stephen Hemminger" <shemminger@xxxxxxxxxx>
> To: "Andrew Stiegmann (stieg)" <astiegmann@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx, acking@xxxxxxxxxx, dtor@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx,
> virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, dsouders@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, cschamp@xxxxxxxxxx
> Sent: Wednesday, May 16, 2012 10:01:21 AM
> Subject: Re: [vmw_vmci RFC 01/11] Apply VMCI context code
> 
> On Tue, 15 May 2012 08:06:58 -0700
> "Andrew Stiegmann (stieg)" <astiegmann@xxxxxxxxxx> wrote:
> 
> > Context code maintains state for vmci and allows the driver
> > to communicate with multiple VMs.
> > 
> > Signed-off-by: Andrew Stiegmann (stieg) <astiegmann@xxxxxxxxxx>
> 
> Running checkpatch reveals the usual noise, and the following that
> should be addressed.
> 
> ERROR: do not use C99 // comments
> #272: FILE: drivers/misc/vmw_vmci/vmci_context.c:183:
> +static bool ctx_exists_locked(uint32_t cid)	// IN
> 
> ERROR: "foo * bar" should be "foo *bar"
> #304: FILE: drivers/misc/vmw_vmci/vmci_context.c:215:
> +		      uid_t * user, struct vmci_ctx **outContext)
> 
> I don't mind the C99 style comments, but the // IN convention
> is pretty useless and should be removed.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/