Re: [PATCH 1/2] mm: Fix slab->page flags corruption.

From: Pravin Shelar
Date: Wed May 16 2012 - 14:40:20 EST


On Mon, May 14, 2012 at 11:53 AM, Christoph Lameter <cl@xxxxxxxxx> wrote:
> On Mon, 14 May 2012, Pravin B Shelar wrote:
>
>> Transparent huge pages can change page->flags (PG_compound_lock)
>> without taking Slab lock. Since THP can not break slab pages we can
>> safely access compound page without taking compound lock.
>>
>> Specificly this patch fixes race between compound_unlock and slab
>> functions which does page-flags update. This can occur when
>> get_page/put_page is called on page from slab object.
>
> You need to also get this revbiewed by the THP folks like Andrea &
> friends.

Hi Andrea,

Can you comment on this patch.

Thanks.

>
> Reviewed-by: Christoph Lameter <cl@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/