Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64_ds

[H. Peter Anvin]

On 05/17/2012 04:51 PM, H. Peter Anvin wrote:
> 
> This patch and the one before it seems to have another problem: we
> currently define __BITS_PER_LONG as:
> 
> #ifdef __x86_64__
> # define __BITS_PER_LONG 64
> #else
> # define __BITS_PER_LONG 32
> #endif
> 

H.J., do you see any problem *other* than this wretched struct
msqid64_ds with changing the above from __x86_64__ to

#if defined(__x86_64__) && !defined(__ILP32__)

... in the above?

As far as struct msqid64_ds,  I think we can fix it simply because x86
is the only compat-aware architecture which has to deal with it.

(Incidentally, if sh is ever expanded to 64 bits, it will have a problem
in the bigendian configuration...)

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/