Re: [ 12/53] net: In unregister_netdevice_notifier unregister thenetdevices.

From: David Miller
Date: Fri May 18 2012 - 01:41:56 EST


From: Herton Ronaldo Krzesinski <herton.krzesinski@xxxxxxxxxxxxx>
Date: Fri, 18 May 2012 02:09:05 -0300

> On Fri, May 18, 2012 at 03:33:06AM +0100, Ben Hutchings wrote:
>> 3.2.18-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
>>
>> [ Upstream commit 7d3d43dab4e978d8d9ad1acf8af15c9b1c4b0f0f ]
>>
>> We already synthesize events in register_netdevice_notifier and synthesizing
>> events in unregister_netdevice_notifier allows to us remove the need for
>> special case cleanup code.
>>
>> This change should be safe as it adds no new cases for existing callers
>> of unregiser_netdevice_notifier to handle.
>
> It seems this introduces a regression later fixed by commit
> c57b54684060c8aced64a5b78ff69ff289af97b9

Indeed, but thankfully that only hits people who try to unload the
pktgen module which is a pretty small group of people :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/