Re: [PATCH] tracing: Merge separate resize loops

[Vaibhav Nagarnaik]

On Fri, May 18, 2012 at 6:56 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Fri, 2012-05-18 at 13:29 -0700, Vaibhav Nagarnaik wrote:
>>
>>               /* wait for all the updates to complete */
>>               for_each_buffer_cpu(buffer, cpu) {
>>                       cpu_buffer = buffer->buffers[cpu];
>> -                     if (!cpu_buffer->nr_pages_to_update||
>> -                         !cpu_online(cpu))
>> +                     if (!cpu_buffer->nr_pages_to_update)
>>                               continue;
>>
>
> Why did you make this change? As we only need to wait for completions.
>
>> -                     wait_for_completion(&cpu_buffer->update_completion);
>> -                     /* reset this value */
>> +                     if (cpu_online(cpu))
>> +                             wait_for_completion(&cpu_buffer->update_done);
>>                       cpu_buffer->nr_pages_to_update = 0;
>
> Or was the original patch buggy, where we never set nr_page_to_update to
> zero for the offline case?

I don't see a bug, since at the start of the resize operation, we
always recalculate this value. It will be reset to 0, if there are no
updates. I set it to zero at the end just as a precautionary measure.


Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/