Re: [patch 20/24] sparc: Use: generic time config

From: Sam Ravnborg
Date: Sun May 20 2012 - 12:53:15 EST


On Fri, May 18, 2012 at 07:50:41PM +0200, Sam Ravnborg wrote:
> Hi Anna-Maria.
>
> I really like the cleanup provided by this patch-set, but..
>
> On Fri, May 18, 2012 at 04:45:54PM -0000, Anna-Maria Gleixner wrote:
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > ---
> > arch/sparc/Kconfig | 15 +++------------
> > 1 file changed, 3 insertions(+), 12 deletions(-)
> >
> > Index: linux/arch/sparc/Kconfig
> > ===================================================================
> > --- linux.orig/arch/sparc/Kconfig
> > +++ linux/arch/sparc/Kconfig
> > @@ -30,11 +30,13 @@ config SPARC
> > select USE_GENERIC_SMP_HELPERS if SMP
> > select GENERIC_PCI_IOMAP
> > select HAVE_NMI_WATCHDOG if SPARC64
> > + select GENERIC_CMOS_UPDATE
>
> I do not see where we define the GENERIC_CMOS_UPDATE symbol,
> so this looks wrong.

Whit the updated 01/24 patch you can add my:

Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/