Re: [PATCH] mfd: lm3533: fix return type of attribute is_visible

[Johan Hovold]

On Sun, May 20, 2012 at 03:19:08PM +0200, Samuel Ortiz wrote:
> Hi Johan,
> 
> On Fri, May 18, 2012 at 01:18:04PM +0200, Johan Hovold wrote:
> > Hi Samuel,
> > 
> > On Fri, May 11, 2012 at 10:40:41AM +0200, Johan Hovold wrote:
> > > Since commit 587a1f1659 ("switch ->is_visible() to returning umode_t")
> > > the return type of is_visible is umode_t rather than mode_t.
> > > 
> > > This silences a compiler warning on some architectures where these types
> > > are not compatible.
> > > 
> > > Reported-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> > > ---
> > 
> > Apparently Dan Carpenter sent a fix for this compiler warning the day
> > after I submitted mine. Dan's patch, however, only fixed the return type
> > and not the type of the mode variable.
> > 
> > Could you consider applying this patch one on top of Dan's (which you
> > applied to mfd-next on Monday)?
> I applied the following chunk:
> 
> @@ -367,7 +367,7 @@ static umode_t lm3533_attr_is_visible(struct kobject *kobj,
>         struct device_attribute *dattr = to_dev_attr(attr);
>         struct lm3533_device_attribute *lattr = to_lm3533_dev_attr(dattr);
>         enum lm3533_attribute_type type = lattr->type;
> -       mode_t mode = attr->mode;
> +       umode_t mode = attr->mode;

Great. Thanks!

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/