re: mm/mpol: Make MPOL_LOCAL a real policy

From: Dan Carpenter
Date: Mon May 21 2012 - 09:38:47 EST


Hello Peter Zijlstra,

The patch 03ed7b538ca0: "mm/mpol: Make MPOL_LOCAL a real policy" from
Mar 19, 2012, leads to the following warning:
mm/mempolicy.c:2591 mpol_parse_str()
error: buffer overflow 'policy_modes' 5 <= 5

mm/mempolicy.c
2590 for (mode = 0; mode < MPOL_MAX; mode++) {
2591 if (!strcmp(str, policy_modes[mode])) {
2592 break;
2593 }
2594 }

The problem is that MPOL_NOOP is not defined in policy_modes[] so we
search past the end of the array.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/