Re: [PATCH] x86: check for valid irq_cfg pointer insmp_irq_move_cleanup_interrupt

[Thomas Gleixner]

On Mon, 21 May 2012, Dimitri Sivanich wrote:

> The smp_irq_move_cleanup_interrupt routine should be checking for a valid
> irq_cfg pointer prior to accessing it.  It also seems that this should be
> done after taking the desc lock.

It seems that you either missed or failed to explain why it should be
done _after_ taking the lock.

Changelogs matter, really.
 
Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/