Re: [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void__iomem *

[Dan Carpenter]

On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote:
> @@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev,
>  	if (ret < 0)
>  		return ret;
>  
> -	devpriv->ioaddr = (void *)(unsigned long)it->options[0];
> +	devpriv->ioaddr = (void __iomem *)(unsigned long)it->options[0];


Obviously, your patch is fine, but I was wondering if it was a
problem that it->options was only a 32 bit?  Seems like it would
deserve a comment.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/