Re: [PATCH] staging: comedi: remove private header comedi_pci.h

From: Ian Abbott
Date: Tue May 22 2012 - 06:06:36 EST


On 2012-05-22 01:12, H Hartley Sweeten wrote:
Remove the private header, comedi_pci.h, by moving the two
helper functions into divers.c and providing the prototypes
in comedidev.h.

This allows the comedi_pci_enable/disable helper functions
to be shared instead of having an inline version in every
comedi pci driver.

I'm wondering if these functions should be EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL() since they were originally inline functions.

Opinions?

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/