Re: [PATCH 1/7] remoteproc: resource table overhaul

From: frq09524
Date: Tue May 22 2012 - 08:52:13 EST


hi Ohad

In my previous patch, to find the correct subdevice that match with physical memory, I used pa member of rproc_mem_entry.
but today in these 2 resources: fw_rsc_trace, fw_rsc_vdev_vring, pa menber has been removed.

for fw_rsc_trace it's not a problem, because use rproc_da_to_va and carveout feature.

but for fw_rsc_vdev_vring, I think use da member, like this.

dev = rproc_dma_find_dev(rproc, (phys_addr_t) vring->da);
va = dma_alloc_coherent(dev, size, &dma, GFP_KERNEL);
if (!va) {
dev_err(dev, "dma_alloc_coherent failed\n");
return -EINVAL;
}

are you OK ?

/BR
Ludovic Barré

On 05/22/2012 11:22 AM, Ohad Ben-Cohen wrote:
Hi Ludovic,

On Tue, May 22, 2012 at 12:14 PM, frq09524<ludovic.barre@xxxxxxxxxxxxxx> wrote:
Ohad, for alignment I can take the latest branch of kernel.org (remoteproc)
branch for-next?

Sure, it's pretty much updated sans a few simple changes.

Thanks,
Ohad.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/