Re: ACPI and NUMA guys, please help to check if this patch is OK

From: ethan zhao
Date: Wed May 23 2012 - 23:08:56 EST


David,
What we can do to help improving Linux OS is only about fatal
error ? Can I do something to give more clear warning information and
easy to find the root cause ?

Thanks,
Ethan

On Wed, May 23, 2012 at 11:30 AM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> On Wed, 23 May 2012, ethan zhao wrote:
>
>> [PATCH] drivers/acpi/numa.c: Add localities checking code against
>> proximity domains to slit_valid()
>>
>>  Some buggy BIOS/ACPI will set different number to SLIT localities and
>> SRAT proximity domains,
>>  That will make NUMA configuration invalid and kernel will output
>> information like following
>>
>> NUMA:Warning:invalid distance parameter, from=-1 to=-1 distance=83
>>
>> This patch adds some checking code to slit_valid() function in order
>> to check theSLIT localities
>> count against SRAT proximity domains number and give clear information
>> about ACPI bug.
>>
>> Signed-off-by: ethan.zhao <ethan.kernel@xxxxxxxxx>
>
> There's nothing in the ACPI spec that prohibits this and the result is
> non-fatal (it only emits a warning of the mismatch), so this patch is
> unnecessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/