Re: pwc driver bugs

From: Alan Cox
Date: Thu May 24 2012 - 11:53:37 EST


On Thu, 24 May 2012 17:03:49 +0200
Udo van den Heuvel <udovdh@xxxxxxxxx> wrote:

> Hello,
>
> I discovered some issues in the pwc driver for certain USB webcams.
> I opened some bugs[1].
> I do think both issues might be related and the crash issue is quite
> serious.
>
> Please have a look, I can assist by testing any patches with fixes. (for
> ~3.3.7)

commit ceede9fa8939e40ad0ddb4ad1355f45c6f1d3478

looks rather relevant here.

commit ceede9fa8939e40ad0ddb4ad1355f45c6f1d3478
Author: Hans de Goede <hdegoede@xxxxxxxxxx>
Date: Wed May 9 04:43:12 2012 -0300

[media] pwc: Fix locking

My last locking rework for pwc mistakenly assumed that videbuf2 does
its own locking, but it does not! This patch fixes the missing
locking by moving over the the video_device lock, and introducing a
separate lock for the videobuf2_queue.

Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/