Re: [PATCH 1/4] async: introduce 'async_domain' type
From: Dan Williams
Date: Fri May 25 2012 - 04:18:30 EST
On Fri, May 25, 2012 at 12:51 AM, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 2012-05-25 at 00:50 -0700, Dan Williams wrote:
>> This is in preparation for teaching async_synchronize_full() to sync all
>> pending async work, and not just on the async_running domain. This
>> conversion is functionally equivalent, just embedding the existing list
>> in a new async_domain type.
>
> This looks good, but I want Arjan and others who invented the async code
> to speed up boot to comment on all of this. What was the intention of
> async_synchronize_full() and if it wasn't to synchronise all domains,
> should we fix the documentation and add a new primitive to do that,
> since boot clearly assumes the all domains behaviour.
>
> In the mean time, this is probably all a bit much for a merge window, so
> I'll revert
>
> commit a7a20d103994fd760766e6c9d494daa569cbfe06
> Author: Dan Williams <dan.j.williams@xxxxxxxxx>
> Date: Thu Mar 22 17:05:11 2012 -0700
>
> [SCSI] sd: limit the scope of the async probe domain
>
> And we'll put whatever is chosen in early for the next merge window.
>
Makes sense... but could also go ahead with the smaller fix I posted
for 3.5. Meelis confirms it is working.
Otherwise this leaves the pending libsas suspend/resume support in
limbo, since it will certainly deadlock in the case where any device
fails, or is slow to come back from resume.
--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/