Re: [PATCH] tty: tty_mutex: fix lockdep warning intty_lock_pair(v1)

From: Alan Cox
Date: Fri May 25 2012 - 10:00:09 EST


On Fri, 25 May 2012 15:52:02 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Fri, 2012-05-25 at 14:47 +0100, Alan Cox wrote:
> > > Having looked at the source I still don't see how it could possibly
> > > work,.. So the problem with tty_release() -> tty_ldisc_release() is
> > > that tty_ldisc_release() does an unlock/lock of tty.
> >
> > Yes it should do the pair, see the patch I posted restructing it, and
> > the second one restructing it right.
>
> http://marc.info/?l=linux-kernel&m=133794355529930
>
> That one? To what tree does one apply that? Because the tty_lock_pair()
> in Linus is still missing a lockdep annotation afaict.

It applies on top of the other patches being tested in the thread on the
lockdep warning.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/