Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions

From: H. Peter Anvin
Date: Fri May 25 2012 - 13:15:06 EST


On 05/25/2012 10:05 AM, Thavatchai Makphaibulcboke wrote:
>> We could do that. But according to the comment in the original
>> implementation, there seems to be a concern regarding its performance
>> speed. If you believe all archs' memcpy would give comparable
>> performance to the memmove. then I could do that.
>>
>
> Also how about the case for overlapping buffer, especially when the
> destination is at a higher address? I do not believe memcpy guarantee
> to work.

memcpy() is not guaranteed to work for any overlap; that is what
memmove() is for.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/