Re: [RFC PATCH v2 0/7] dmaengine: enhance dmaengine to support DMAdevice hotplug

From: Jiang Liu
Date: Sat May 26 2012 - 12:39:37 EST


Hi Taku,
Sorry, forgot to export the percpu variable. Could you please
help to test the patch below?
Thanks!
---
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 8a41bdf..26316f6 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -73,6 +73,7 @@ static atomic_t dmaengine_dirty;
static struct static_key dmaengine_quiesce = STATIC_KEY_INIT_FALSE;
static DECLARE_WAIT_QUEUE_HEAD(dmaengine_wait_queue);
DEFINE_PER_CPU(long, dmaengine_chan_ref_count);
+EXPORT_PER_CPU_SYMBOL(dmaengine_chan_ref_count);
#endif /* CONFIG_DMA_ENGINE_HOTPLUG */

/* --- sysfs implementation --- */

On 05/25/2012 08:49 AM, Taku Izumi wrote:
> Hi Jiang,
>
> Build failed with "Device Drivers/DMA Engine Support/Async_tx: Offload
> support for the async_tx api" enabled because of undefined symbol.
> Patch 5/7 needs a fix?
>
> (snip)
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CHK include/linux/version.h
> make[2]: Nothing to be done for `all'.
> Building modules, stage 2.
> TEST posttest
> MODPOST 2201 modules
> Succeed: decoded and checked 1356146 instructions
> TEST posttest
> Success: decoded and checked 1000000 random instructions with 0 errors (seed:0x9432fb9e)
> Kernel: arch/x86/boot/bzImage is ready (#13)
> ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_xor.ko] undefined!
> ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_raid6_recov.ko] undefined!
> ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_pq.ko] undefined!
> ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_memcpy.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Best regards,
> Taku Izumi <izumi.taku@xxxxxxxxxxxxxx>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/