Re: [PATCH] tty: tty_mutex: fix lockdep warning in tty_lock_pair(v3)

From: Ming Lei
Date: Sun May 27 2012 - 00:37:56 EST


Hi,

On Sun, May 27, 2012 at 12:39 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Sat, 2012-05-26 at 17:23 +0800, Ming Lei wrote:
>>
>> You mean that the below is good usage of lock?
>>
>>         LOCK A
>>         LOCK B
>>
>>         UNLOCK A
>>         UNLOCK B
>
> Yep, nothing wrong with that. Its lock order that matters, unlock very
> much not so.

OK.

Also I tested your patch in the link below again and it is OK.

http://marc.info/?l=linux-kernel&m=133728068726465&w=2

Sorry for my fault because the patch above can't be applied cleanly
against -next and I edited it manually to cause the previous test
mistake.

Greg and Peter, so I recall this patch and Peter may send a formal
one for merge.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/