Re: [PATCH 12/13] backlight: tosa_bl: use devm_ functions

From: Mark Brown
Date: Mon May 28 2012 - 08:48:32 EST


On Sat, May 26, 2012 at 10:43:07AM +0400, Dmitry Eremin-Solenikov wrote:
> On Fri, May 25, 2012 at 6:30 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:

> > The devm_ functions allocate memory that is released when a driver
> > detaches. This patch uses devm_kzalloc of these functions.

> Strictly speaking I see no point in this changes. There are no
> 'missing free' problems
> in these drivers, the code path is clean enough. Is devm_kzalloc usage some kind
> of policy, or it is just a future-proof change?

It does provide robustness against future changes and it's also the more
current style; if nothing else it helps anyone who wants to go and audit
for leaks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/