Re: [PATCH] memcg: remove the unnecessary MEM_CGROUP_STAT_DATA

[Chen Baozi]

On May 28, 2012, at 9:39 PM, Michal Hocko wrote:

> On Fri 25-05-12 16:11:41, Chen Baozi wrote:
>> Since MEM_CGROUP_ON_MOVE has been removed, it comes to be redudant
>> to hold MEM_CGROUP_STAT_DATA to mark the end of data requires
>> synchronization.
> 
> A similar patch has been already posted by Johannes 2 weeks ago
> (http://www.gossamer-threads.com/lists/linux/kernel/1535888) and it
> should appear in -next soonish.
Oh, I see, Thanks for informing.

Baozi

> 
>> 
>> Signed-off-by: Chen Baozi <baozich@xxxxxxxxx>
>> ---
>> mm/memcontrol.c |    3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>> 
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index f342778..446ca94 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -88,7 +88,6 @@ enum mem_cgroup_stat_index {
>> 	MEM_CGROUP_STAT_RSS,	   /* # of pages charged as anon rss */
>> 	MEM_CGROUP_STAT_FILE_MAPPED,  /* # of pages charged as file rss */
>> 	MEM_CGROUP_STAT_SWAPOUT, /* # of pages, swapped out */
>> -	MEM_CGROUP_STAT_DATA, /* end of data requires synchronization */
>> 	MEM_CGROUP_STAT_NSTATS,
>> };
>> 
>> @@ -2139,7 +2138,7 @@ static void mem_cgroup_drain_pcp_counter(struct mem_cgroup *memcg, int cpu)
>> 	int i;
>> 
>> 	spin_lock(&memcg->pcp_counter_lock);
>> -	for (i = 0; i < MEM_CGROUP_STAT_DATA; i++) {
>> +	for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) {
>> 		long x = per_cpu(memcg->stat->count[i], cpu);
>> 
>> 		per_cpu(memcg->stat->count[i], cpu) = 0;
>> -- 
>> 1.7.1
>> 
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
>> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
> 
> -- 
> Michal Hocko
> SUSE Labs
> SUSE LINUX s.r.o.
> Lihovarska 1060/12
> 190 00 Praha 9    
> Czech Republic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/