[PATCH v1] x86/irq: handle chained interrupts during IRQ migration

From: Sundar Iyer
Date: Tue May 29 2012 - 09:21:16 EST


Chained interrupt handlers dont have an irqaction and hence are not
handled during migrating interrupts when some cores go offline.

Handle this by introducing a irq_is_chained() check which is based
on the IRQ_NOREQUEST flag being set for such interrupts. fixup_irq()
can then handle such interrupts and not skip them over.

Signed-off-by: Sundar Iyer <sundar.iyer@xxxxxxxxx>
---
v1: use accessors instead of new variables to identify chained irqs

arch/x86/kernel/irq.c | 6 ++++--
include/linux/irqdesc.h | 10 ++++++++++
2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 6c0802e..acd7949 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -249,8 +249,10 @@ void fixup_irqs(void)

data = irq_desc_get_irq_data(desc);
affinity = data->affinity;
- if (!irq_has_action(irq) || irqd_is_per_cpu(data) ||
- cpumask_subset(affinity, cpu_online_mask)) {
+ /* include IRQs who have no action, but are chained */
+ if ((!irq_has_action(irq) && irq_is_chained(irq)) ||
+ irqd_is_per_cpu(data) ||
+ cpumask_subset(affinity, cpu_online_mask)) {
raw_spin_unlock(&desc->lock);
continue;
}
diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h
index 2d921b3..7880722 100644
--- a/include/linux/irqdesc.h
+++ b/include/linux/irqdesc.h
@@ -120,6 +120,16 @@ static inline int irq_has_action(unsigned int irq)
return desc->action != NULL;
}

+/*
+ * Test to see if the IRQ is chained; it would not be requested and hence
+ * _IRQ_NOREQUEST would be set
+ */
+static inline int irq_is_chained(unsigned int irq)
+{
+ struct irq_desc *desc = irq_to_desc(irq);
+ return !(desc->status_use_accessors & IRQ_NOREQUEST);
+}
+
/* caller has locked the irq_desc and both params are valid */
static inline void __irq_set_handler_locked(unsigned int irq,
irq_flow_handler_t handler)
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/