Re: [PATCH 16/22] mfd: ab8500-gpadc: Enable IRQF_ONESHOT whenrequesting a threaded IRQ

[Linus Walleij]

On Wed, May 30, 2012 at 12:47 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  drivers/mfd/ab8500-gpadc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> index c39fc71..358d502 100644
> --- a/drivers/mfd/ab8500-gpadc.c
> +++ b/drivers/mfd/ab8500-gpadc.c
> @@ -599,7 +599,8 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev)
>        /* Register interrupt  - SwAdcComplete */
>        ret = request_threaded_irq(gpadc->irq, NULL,
>                ab8500_bm_gpswadcconvend_handler,
> -               IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc", gpadc);
> +               IRQF_ONESHOT | IRQF_NO_SUSPEND | IRQF_SHARED,
> +                               "ab8500-gpadc", gpadc);

Looks correct to me I think this one should be ONESHOT anyway.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/