Re: [PATCH repost] virtio-net: remove useless disable on freeze

From: David Miller
Date: Wed May 30 2012 - 16:36:12 EST


From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Wed, 30 May 2012 17:21:29 +0300

> disable_cb is just an optimization: it
> can not guarantee that there are no callbacks.
> In particular it doesn't have any effect when
> event index is on.
>
> Instead, detach, napi disable and reset on freeze ensure we don't run
> concurrently with a callback.
>
> Remove the useless calls so we get same behaviour
> with and without event index.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
>
> Reposting a patch that seems to have fallen through cracks.

It seems to not make it to the lists and get properly picked up
by patchwork.

In any event, I've applied this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/