Re: [PATCH] 8021q/vlan: process NETDEV_GOING_DOWN

From: David Miller
Date: Wed May 30 2012 - 17:51:24 EST


From: Eldad Zack <eldad@xxxxxxxxxxxxxxx>
Date: Wed, 30 May 2012 23:47:32 +0200 (CEST)

>
> On Wed, 30 May 2012, David Miller wrote:
>> From: Eldad Zack <eldad@xxxxxxxxxxxxxxx>
>> Date: Wed, 30 May 2012 21:11:02 +0200 (CEST)
>>
>> > In case a certain protocol needs to send a "dying gasp" packet, when you
>> > administrativly shutdown the port (which is also what happens when you
>> > restart the machine).
>>
>> No in tree users have this requirement, therefore your patch is
>> inappropriate.
>
> You are right in that, that no in tree users have this requirement
> (yet), but in the same time it doesn't harm any existing code.
>
> Don't you agree that it's the right order to do the notifications?

It's not an issue that matters upstream, so I simply do not care.

When you, or someone else, submits code that needs this facility
then we can talk about it.

Otherwise it's just a waste of our time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/