Re: [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variablein generic code

From: Srivatsa S. Bhat
Date: Fri Jun 01 2012 - 08:56:46 EST


On 06/01/2012 05:55 PM, Russell King - ARM Linux wrote:

> On Fri, Jun 01, 2012 at 05:49:14PM +0530, Srivatsa S. Bhat wrote:
>> Adding arch maintainers to Cc, which I had missed earlier. No changes to the
>> patch.
>
> Could someone explain what this variable does - afaics this patch adds
> this per-cpu variable to all SMP architectures where its required or
> not, and (so far) the generic code just writes one value to it.
>


Several architectures use this per-cpu variable to track the state of the cpu
(like CPU_DEAD), particularly to deal with cpu offline.

(At this point, we have just tried to generalize code without any major
functional changes.)


> Are there plans to make use of this in other generic code?
>


The idea of this patchset is to make smp booting and cpu hotplug code as
generic as possible and eventually have _one_ implementation in the generic
code which can be reused by all architectures that want it.

And this patchset generalizes only the booting of secondary cpus. But in
future, we can use this as a base and implement cpu hotplug handling in
generic code, where this variable will become more useful.


Regards,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/