Re: [PATCH 05/20] hexagon: Do not call do_signal() with irqsdisabled

From: Richard Kuo
Date: Fri Jun 01 2012 - 15:02:01 EST


On Sat, May 26, 2012 at 12:04:21AM +0200, Richard Weinberger wrote:
> get_signal_to_deliver() calls try_to_freeze() which might sleep.
>
> Cc: Richard Kuo <rkuo@xxxxxxxxxxxxxx>
> Cc: linux-hexagon@xxxxxxxxxxxxxxx
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> arch/hexagon/kernel/signal.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> index 434866e..8403bfd 100644
> --- a/arch/hexagon/kernel/signal.c
> +++ b/arch/hexagon/kernel/signal.c
> @@ -22,6 +22,7 @@
> #include <linux/syscalls.h>
> #include <linux/freezer.h>
> #include <linux/tracehook.h>
> +#include <linux/irqflags.h>
> #include <asm/registers.h>
> #include <asm/thread_info.h>
> #include <asm/unistd.h>
> @@ -267,6 +268,8 @@ no_restart:
>
> void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
> {
> + local_irq_enable();
> +
> if (thread_info_flags & _TIF_SIGPENDING)
> do_signal(regs);
>
> --
> 1.7.7.3
>

Acked-by: Richard Kuo <rkuo@xxxxxxxxxxxxxx>


--

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/