Re: [PATCH v3.5-rc1] blkcg: fix blkg_alloc() failure path

From: Jens Axboe
Date: Mon Jun 04 2012 - 09:24:00 EST


On 06/04/2012 08:21 AM, Tejun Heo wrote:
> When policy data allocation fails in the middle, blkg_alloc() invokes
> blkg_free() to destroy the half constructed blkg. This ends up
> calling pd_exit_fn() on policy datas which didn't go through
> pd_init_fn(). Fix it by making blkg_alloc() call pd_init_fn()
> immediately after each policy data allocation.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
> ---
> Jens, this was posted as part of "block: implement per-blkg request
> allocation" patchset[1] but should be applied as fix on v3.5-rc1.

Applied for 3.5 current, thanks.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/