Re: [PATCH] ohci-nxp: Use ohci_finish_controller_resume()

From: Roland Stigge
Date: Mon Jun 04 2012 - 11:02:26 EST


Hi!

On 06/04/2012 04:29 PM, Alan Stern wrote:
>> OHCI drivers are supposed to use ohci_finish_controller_resume(). This patch
>> adds respective suspend and resume code to ohci-nxp. The following compiler
>> warning is fixed this way:
>>
>> drivers/usb/host/ohci-hub.c:321: warning: 'ohci_finish_controller_resume'
>> defined but not used
>
> This is not a correct description of the patch. A correct description
> would be something like:
>
> Add suspend/resume support to the ohci-nxp driver.
>
> The compiler warning needs a completely different fix;
> ohci_finish_controller_resume should be given a __maybe_unused
> annotation.

Thanks for the suggestion! I'll rather do the latter.

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/