Re: [PATCH v2] remove no longer use of pdflush interface

From: Wanpeng Li
Date: Wed Jun 06 2012 - 06:56:02 EST


On Wed, Jun 06, 2012 at 10:31:12AM +0300, Boaz Harrosh wrote:
>
>If there are many users than a self made print once is worth it
>we can use the ctl_table->data pointer for this, some thing like:
>
>int nr_pdflush_was_printed;
>
>@@ -1095,11 +1095,9 @@ static struct ctl_table vm_table[] = {
> .extra1 = &zero,
> },
> {
>- .procname = "nr_pdflush_threads",
>- .data = &nr_pdflush_threads,
>- .maxlen = sizeof nr_pdflush_threads,
>- .mode = 0444 /* read-only*/,
>- .proc_handler = proc_dointvec,
>+ .data = &nr_pdflush_was_printed,
>+ .procname = "nr_pdflush_threads",
>+ .mode = 0444 /* read-only */,
>+ .proc_handler = proc_obsolete,
> },
>
>
>+/* notice associated proc deprecated */
>+int proc_deprecated(struct ctl_table *table, int write,
>+ void __user *buffer, size_t *lenp, loff_t *ppos, )
>+{
>+ if (*ctl_table->data) {
>+ printk(KERN_WARNING "%s exported in /proc is deprecated\n",
>+ table->procname);
>+ *ctl_table->data = 0;
>+ }
>+ return -ENOSYS;
>+}

But this time you add another variable nr_pdflush_was_printed.
So remove variable nr_pdflush_threads does not make sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/