Re: [PATCH 5/7]drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bitoperation

From: Franky Lin
Date: Wed Jun 06 2012 - 19:44:31 EST


On 06/06/2012 02:41 PM, Julia Lawall wrote:
From: Julia Lawall<Julia.Lawall@xxxxxxx>

IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall<julia@xxxxxxx>

Thanks, Julia. But this has already been fixed by Joe Perches [1] and the patch has arrived at Linux wireless tree.

Franky

[1] https://lkml.org/lkml/2012/5/30/482

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/