Re: processes hung after sys_renameat, and 'missing' processes

From: Dave Jones
Date: Wed Jun 06 2012 - 22:08:51 EST


On Thu, Jun 07, 2012 at 02:54:10AM +0100, Al Viro wrote:

> > Do you even need the "dentry->d_parent != dentry" test? When do we
> > even rename root dentries?
>
> Root of the filesystem - never; root of disconnected subtree - sure,
> that's how they become connected to the tree. See d_materialize_unique(),
> for example...
>
> BTW, I really need more coffee - those checks belong in __d_move(),
> not d_move(); aforementioned d_materialize_unique() doesn't use d_move(),
> it calls __d_move() directly. Sorry.

np, I'll restart the build/test.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/