Re: [PATCH 1/9] Staging: ipack/bridges/tpci200: remove gotos intpci200_free_irq().

From: Dan Carpenter
Date: Thu Jun 07 2012 - 04:39:41 EST


On Thu, Jun 07, 2012 at 10:24:50AM +0200, Miguel Gómez wrote:
> Handle error conditions with simple returns instead of usig gotos.
>
> Signed-off-by: Miguel Gómez <magomez@xxxxxxxxxx>

Nope. It was still supposed to release the lock on success.

Keep the out_unlock label, and remove the out label.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/