Re: [PATCH] gpiolib: wm8994: Pay attention to the value set whenenabling as output

From: Linus Walleij
Date: Thu Jun 07 2012 - 07:11:17 EST


On Tue, Jun 5, 2012 at 7:12 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> +       if (value)
> +               value = WM8994_GPN_LVL;
> +
>        return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset,
> -                              WM8994_GPN_DIR, 0);
> +                              WM8994_GPN_DIR | WM8994_GPN_LVL, value);
>  }

The commit message is so terse compared to what the code does that
I cannot claim to understand what this patch is doing.

Could you elaborate on the problem ans symptoms, just for a nice
commit log?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/