Re: [PATCH V2 1/2] pinctrl: pinctrl-imx: free allocatedpinctrl_map structure only once and use kernel facilities for IMX_PMX_DUMP

From: Dong Aisheng
Date: Thu Jun 07 2012 - 23:00:47 EST


On Thu, Jun 07, 2012 at 10:18:35PM +0530, Devendra Naga wrote:
> a) as we allocate the pinctrl_map structure at imx_dt_node_to_map at line 167, anyway
> if its an element, or a num_elements * (sizeof(type)) elements allocated to one single
> pointer must be freed only once.
>
> CASE. A)
>
> as new_map is not moved and allocated like,
>
> for (i = 0; i < MAX_ELEMS; i++) {
> new_map[i] = kmalloc(numelems * size, GFP_KERNEL);
> }
>
> its freed as
>
> for (i = 0; i < MAX_ELEMS; i++) {
> kfree(new_map[i]);
> }
>
> CASE. B)
> and its allocated like
> new_map = kmalloc(numelems * size, GFP_KERNEL);
>
> it just needs kfree not as case A's.
>
> b) use KERN_DEBUG facility for the IMX_PMX_DUMP macro.
>
> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
> Acked-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
> ---
> drivers/pinctrl/pinctrl-imx.c | 25 +++++++++++--------------
> 1 file changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
> index f6e7c67..7a59a59 100644
> --- a/drivers/pinctrl/pinctrl-imx.c
> +++ b/drivers/pinctrl/pinctrl-imx.c
> @@ -27,16 +27,16 @@
> #include "core.h"
> #include "pinctrl-imx.h"
>
> -#define IMX_PMX_DUMP(info, p, m, c, n) \
> -{ \
> - int i, j; \
> - printk("Format: Pin Mux Config\n"); \
> - for (i = 0; i < n; i++) { \
> - j = p[i]; \
> - printk("%s %d 0x%lx\n", \
> - info->pins[j].name, \
> - m[i], c[i]); \
> - } \
> +#define IMX_PMX_DUMP(info, p, m, c, n) \
> +{ \
> + int i, j; \
> + printk(KERN_DEBUG "Format: Pin Mux Config\n"); \
> + for (i = 0; i < n; i++) { \
> + j = p[i]; \
> + printk(KERN_DEBUG "%s %d 0x%lx\n", \
> + info->pins[j].name, \
> + m[i], c[i]); \
> + } \
> }
>
Sorry i missed one more comment.
I think you may also need add below changes since the #ifdef DEBUG
is not needed anymore after using KERN_DEBUG.

diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index d8fe1d8..4d073ef 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -475,9 +475,8 @@ static int __devinit imx_pinctrl_parse_groups(struct device_node *np,
grp->configs[j] = config & ~IMX_PAD_SION;
}

-#ifdef DEBUG
IMX_PMX_DUMP(info, grp->pins, grp->mux_mode, grp->configs, grp->npins);
-#endif
+
return 0;
}

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/