Re: [PATCH] perf/x86: check ucode before disabling PEBS onSandyBridge

From: Peter Zijlstra
Date: Fri Jun 08 2012 - 10:25:09 EST


On Fri, 2012-06-08 at 16:07 +0200, Stephane Eranian wrote:
> > +static const u32 snb_ucode_rev = 0x28;
> > +
>
> That needs to be a per CPU model value. It
> is not the same for SNB vs. SNB-EP. On EP
> it may even depends on stepping.

Yeah, you said, easiest is removing the const and putting some
assignments to the thing somewhere in our model switch.

Do you know what values for what chip we should use?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/