[PATCH 2/3] xtensa: Use "test -e" instead of bashism "test -a"

From: Geert Uytterhoeven
Date: Sun Jun 10 2012 - 10:40:06 EST


On Ubuntu, /bin/sh is a symlink to dash, which does not support "test -a".
This causes messages like

test: 1: -a: unexpected operator
test: 1: -a: unexpected operator

and link failures like

(.init.text+0x132): undefined reference to `platform_init'

due to the appropriate platform code not being compiled.

Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Cc: linux-kbuild@xxxxxxxxxxxxxxx
---
arch/xtensa/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/xtensa/Makefile b/arch/xtensa/Makefile
index d41f9ed..1537a0a 100644
--- a/arch/xtensa/Makefile
+++ b/arch/xtensa/Makefile
@@ -68,8 +68,8 @@ core-$(CONFIG_EMBEDDED_RAMDISK) += arch/xtensa/boot/ramdisk/

# Only build variant and/or platform if it includes a Makefile

-buildvar := $(shell test -a $(srctree)/arch/xtensa/variants/$(VARIANT)/Makefile && echo arch/xtensa/variants/$(VARIANT)/)
-buildplf := $(shell test -a $(srctree)/arch/xtensa/platforms/$(PLATFORM)/Makefile && echo arch/xtensa/platforms/$(PLATFORM)/)
+buildvar := $(shell test -e $(srctree)/arch/xtensa/variants/$(VARIANT)/Makefile && echo arch/xtensa/variants/$(VARIANT)/)
+buildplf := $(shell test -e $(srctree)/arch/xtensa/platforms/$(PLATFORM)/Makefile && echo arch/xtensa/platforms/$(PLATFORM)/)

# Find libgcc.a

--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/