Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk onusb hdd

[Namjae Jeon]

2012/6/11, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>:
> On Sat, 9 Jun 2012, Namjae Jeon wrote:
>
>> Add support for write cache quirk on usb hdd. scsi driver will be set to
>> wce
>> by detecting write cache quirk in quirk list when plugging usb hdd.
>
>> --- a/include/linux/usb_usual.h
>> +++ b/include/linux/usb_usual.h
>> @@ -64,7 +64,9 @@
>>  	US_FLAG(NO_READ_CAPACITY_16,	0x00080000)		\
>>  		/* cannot handle READ_CAPACITY_16 */		\
>>  	US_FLAG(INITIAL_READ10,	0x00100000)			\
>> -		/* Initial READ(10) (and others) must be retried */
>> +		/* Initial READ(10) (and others) must be retried */	\
>> +	US_FLAG(WRITE_CACHE,	0x00200000)			\
>> +		/* Write Cache status is not available */
>
> The documentation for the new flag should be added in the same patch
> along with the flag itself.  There's no reason to have separate
> patches.
Hi. Alan.
Okay, I see. I will merge documentation patch with this patch.
Thank you.

>
> Alan Stern
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/