Re: [PATCH] Remove lib/mpi/generic_mpi-asm-defs.h

[Kasatkin, Dmitry]

Hello,

Indeed like that...
That patch has been already reverted and unused code removed.
Changes are available in the #next-queue branch of Linux security tree.

Thanks!

- Dmitry

On Fri, Jun 8, 2012 at 6:33 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> This header got added by commit 7e8dec918ef8e0f68b4937c3c50fa57002077a4d
> ("crypto: GnuPG based MPI lib - additional sources (part 4)"). Nothing
> includes it.
>
> The sole named constant it defines is BYTES_PER_MPI_LIMB. That named
> constant is already provided by <linux/mpi.h> (which is made available
> to the files in lib/mpi via mpi-internal.h). In this header that define
> depends on the undefined macro SIZEOF_UNSIGNED_LONG.
>
> So this header is unused, unneeded and broken. It can safely be removed.
>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> This patch is, once again, tested only with "git grep".
>
> Âlib/mpi/generic_mpi-asm-defs.h | Â Â4 ----
> Â1 files changed, 0 insertions(+), 4 deletions(-)
> Âdelete mode 100644 lib/mpi/generic_mpi-asm-defs.h
>
> diff --git a/lib/mpi/generic_mpi-asm-defs.h b/lib/mpi/generic_mpi-asm-defs.h
> deleted file mode 100644
> index 047d1f5..0000000
> --- a/lib/mpi/generic_mpi-asm-defs.h
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -/* This file defines some basic constants for the MPI machinery. ÂWe
> - * need to define the types on a per-CPU basis, so it is done with
> - * this file here. Â*/
> -#define BYTES_PER_MPI_LIMB Â(SIZEOF_UNSIGNED_LONG)
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/