Re: [PATCH v3 08/10] mm: frontswap: add tracing support

From: Pekka Enberg
Date: Mon Jun 11 2012 - 04:33:05 EST


On 06/10/2012 07:51 PM, Sasha Levin wrote:
>> Add tracepoints to frontswap API.
>>
>> Signed-off-by: Sasha Levin <levinsasha928@xxxxxxxxx>

On Mon, Jun 11, 2012 at 9:12 AM, Minchan Kim <minchan@xxxxxxxxxx> wrote:
> Normally, adding new tracepoint isn't easy without special reason.
> I'm not sure all of frontswap function tracing would be valuable.
> Shsha, Why do you want to add tracing?
> What's scenario you want to use tracing?

Yup, the added tracepoints look more like function tracing. Shouldn't
you use something like kprobes or ftrace/perf for this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/