Re: [PATCH v2] clock: max77686: Add driver for Maxim 77686 32KHzcrystal oscillator
From: Mark Brown
Date: Mon Jun 11 2012 - 05:14:11 EST
On Mon, Jun 11, 2012 at 04:35:31PM +0900, Jonghwa Lee wrote:
> +static int max77686_clk_enable(struct clk_hw *hw)
> +static void max77686_clk_disable(struct clk_hw *hw)
These need to be prepare() and unprepare() since these operations are
atomic.
> +{
> + struct max77686_clk *max77686 = NULL;
The assignments here are redundant since you assign to the variable
immadiately.
> + for ( i = 0; i < MAX77686_CLKS_NUM; i++) {
Coding style with ( i.
Attachment:
signature.asc
Description: Digital signature