Re: [PATCH -V8 15/16] hugetlb/cgroup: migrate hugetlb cgroup info from oldpage to new page during migration

From: Aneesh Kumar K.V
Date: Mon Jun 11 2012 - 06:17:44 EST


Michal Hocko <mhocko@xxxxxxx> writes:

> On Sat 09-06-12 14:30:00, Aneesh Kumar K.V wrote:
>> From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx>
>>
>> With HugeTLB pages, hugetlb cgroup is uncharged in compound page
>> destructor. Since we are holding a hugepage reference,
>
> Who is holding that reference? I do not see anybody calling get_page in
> this patch...
>

soft_offline_huge_page takes the reference. It does the final
put_page(hpage) there.

>> we can be sure that old page won't get uncharged till the last
>> put_page().
>>

-aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/