Re: [PATCH v3] clock: max77686: Add driver for Maxim 77686 32KHzcrystal oscillator

[Mark Brown]

On Mon, Jun 11, 2012 at 08:01:20PM +0900, Jonghwa Lee wrote:

> v3
>  - Add mutex to the max77686_clk structure to make atomic execution of enable/disable function.

No, you've not understood the issue.  As I said on my previous review
these need to be prepare() and unprepare() since enable() and disable()
execute in atomic context - that means you can't do I2C I/O and you
can't take mutexes.

Attachment: signature.asc
Description: Digital signature