Re: [PATCH] driver core: fix shutdown races with probe/remove(v2)

[Alan Stern]

On Mon, 11 Jun 2012, Ming Lei wrote:

> On Mon, Jun 11, 2012 at 10:16 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> >> +
> >> +             if (nonlocked)
> >> +                     dev_err(dev, "can't hold %slock for shutdown\n",
> >> +                                     nonlocked == 1 ? "" : "parent ");
> >
> > Even if the parent can't be locked, you should still try to lock the
> > device.
> 
> I have considered doing it, but which may consume another 1sec.
> 
> Also if the parent lock has been held, it is very possibly that the
> device can't be probed or removed at the same time, so just logged
> the crazy thing and go ahead.

Okay.  Then you can add my Acked-by.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/