Re: [PATCH] edac: rewrite the sysfs code to use struct device

[Mauro Carvalho Chehab]

Em 08-06-2012 09:52, Borislav Petkov escreveu:
>  From c0d119126e1b6daf9fe71614971233ffc90a873a Mon Sep 17 00:00:00 2001
> From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Date: Mon, 16 Apr 2012 16:41:11 -0300
> Subject: [PATCH] edac: rewrite the sysfs code to use struct device
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 

<skip/>

[will check the UTF-8 issue later]

> 
> Hrrm,
> 
> this patch doesn't build here, ontop of 3.5-rc1, config attached.
> 
> In file included from arch/x86/kernel/nmi.c:23:0:
> include/linux/edac.h:452:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:488:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:498:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:553:18: error: field ‘dev’ has incomplete type
> include/linux/edac.h:554:20: error: field ‘bus’ has incomplete type
> make[2]: *** [arch/x86/kernel/nmi.o] Error 1
> make[1]: *** [arch/x86/kernel] Error 2
> make[1]: *** Waiting for unfinished jobs....
> In file included from drivers/edac/edac_stub.c:16:0:
> include/linux/edac.h:452:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:488:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:498:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:553:18: error: field ‘dev’ has incomplete type
> include/linux/edac.h:554:20: error: field ‘bus’ has incomplete type
> make[2]: *** [drivers/edac/edac_stub.o] Error 1
> make[1]: *** [drivers/edac] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [arch/x86] Error 2
> make: *** Waiting for unfinished jobs....
> 

I'll fold the enclosed patch. It should fix this issue.

diff --git a/include/linux/edac.h b/include/linux/edac.h
index aeaafd0..a2b0b6f 100644
--- a/include/linux/edac.h
+++ b/include/linux/edac.h
@@ -13,6 +13,7 @@
 #define _LINUX_EDAC_H_
 
 #include <linux/atomic.h>
+#include <linux/device.h>
 #include <linux/kobject.h>
 #include <linux/completion.h>
 #include <linux/workqueue.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/