Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register accessMacro to head file.

[Wolfram Sang]

On Fri, May 25, 2012 at 03:46:06PM +0530, Shubhrajyoti Datta wrote:
> On Fri, May 25, 2012 at 3:42 PM, Zhang, Sonic <Sonic.Zhang@xxxxxxxxxx> wrote:
> >
> >
> >>-----Original Message-----
> >>From: Shubhrajyoti Datta [mailto:omaplinuxkernel@xxxxxxxxx]
> >>Sent: Friday, May 25, 2012 6:10 PM
> >>To: Zhang, Sonic
> >>Cc: Ben Dooks; Wolfram Sang; linux-i2c@xxxxxxxxxxxxxxx; LKML; uclinux-dist-
> >>devel@xxxxxxxxxxxxxxxxxxxx
> >>Subject: Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access
> >>Macro to head file.
> >>
> >>Hi ,
> >>On Fri, May 25, 2012 at 3:24 PM, Zhang, Sonic <Sonic.Zhang@xxxxxxxxxx>
> >>wrote:
> >>>
> >>>
> >>>>-----Original Message-----
> >>>>From: Shubhrajyoti Datta [mailto:omaplinuxkernel@xxxxxxxxx]
> >>>>Sent: Friday, May 25, 2012 5:48 PM
> >>>>To: Zhang, Sonic
> >>>>Cc: Ben Dooks; Wolfram Sang; linux-i2c@xxxxxxxxxxxxxxx; LKML; uclinux-dist-
> >>>>devel@xxxxxxxxxxxxxxxxxxxx
> >>>>Subject: Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access
> >>>>Macro to head file.
> >>>>
> >>>>Hi ,
> >>>>Some minor comments/ doubts.
> >>>>On Wed, May 16, 2012 at 12:50 PM,  <sonic.zhang@xxxxxxxxxx> wrote:
> >>>>> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> >>>>>
> >>>>
> >>>>A small description may be helpful.
> >>>>Also the $SUBJECT says move the patch looks more like the remove.
> >>>>Am I missing something.
> >>>
> >>> The subject says these definitions are moved to a head file by the other patch
> >>for Blackfin architecture.
> >>
> >>Got it thanks.
> >>
> >>You may want to add a dependency otherwise it might lead to a compilation break?
> >>
> >
> > That patch for Blackfin architecture has already been merged into mainline.
> Great,
> 
> Apologies for the noise.

I don't think this is noise, I agree with you. I'd like to see the
commit which added that and the reasoning. Usually, encapsulating the
accesses in the driver is good, because no one else should bother.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature