Re: [PATCH] mm: clean up __count_immobile_pages

From: Andrew Morton
Date: Mon Jun 11 2012 - 17:40:11 EST


On Mon, 11 Jun 2012 11:07:22 +0900
Minchan Kim <minchan@xxxxxxxxxx> wrote:

> __count_immobile_pages naming is rather awkward.
> This patch clean up the function and add comment.

This conflicts with
mm-compaction-handle-incorrect-migrate_unmovable-type-pageblocks.patch
and its fixes.

> + * This function can race in PageLRU and MIGRATE_MOVABLE can have unmovable
> + * pages so that it might be not exact.

I don't understand this. Functions race against other functions, not
against a page flag. Can we have another attempt at this description
please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/