Re: [PATCH 06/14] mfd: Initialise the DB8500 PRCMU driver at core_initcalltime

From: Lee Jones
Date: Tue Jun 12 2012 - 04:36:02 EST


On 11/06/12 22:01, Linus Walleij wrote:
On Mon, Jun 11, 2012 at 5:24 PM, Lee Jones<lee.jones@xxxxxxxxxx> wrote:

Now the AB8500 has its own IRQ domain

But that does not appear until patch 8 in this series? Are the patches in
the wrong order? Or does this need rewording?

it needs to be initialised earlier
in the boot sequence. As the AB8500 relies on the DB8500 PRCMU we need to
reflect this change for the PRCMU driver too.

Hm what shall we do when we run out of initlevels? I think this was the
kind of thing that deferred probe should solve. Usually changing this kind
of thing has side effects so I'm a bit hesitant.

Ah yes, I remember now. The IRQ domain needs to be in place _before_ the Device Tree is parsed by the Open Firmware subsystem. If it's not the error "no irq domain found" is triggered and the IRQs are never mapped.

I'd be happy to take a second opinion, but I believe this (and the other core_initcall patch) is required.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/