Re: [PATCH V5 0/13] perf: Intel uncore pmu counting support

From: Stephane Eranian
Date: Tue Jun 12 2012 - 11:38:47 EST


On Tue, Jun 12, 2012 at 7:37 AM, Yan, Zheng <zheng.z.yan@xxxxxxxxx> wrote:
> Hi, all
>
> Here is the V5 patches to add uncore counting support for Nehalem,
> Sandy Bridge and Sandy Bridge-EP, applied on top of current tip.
> The code is based on Lin Ming's old patches.
>
> For Nehalem and Sandy Bridge-EP, A few general events are exported
> under sysfs directory:
> Â/sys/bus/event_source/devices/${uncore_dev}/events/
>
On NHM, I tried:
perf stat -a -e Uncore/CLOCKTICKS/
invalid or unsupported event: 'Uncore/CLOCKTICKS/'

I started tracking this down but gave up because it's coming
once again from the too complex parser. You are looking for
a format match (inv, edge, cmask) with the word CLOCKTICKS
instead of config.

Please fix this.

Also I don't think using upper case for the PMU name is a good idea.
Just call it uncore.


> Each file in the events directory defines an event. The content is
> a string such as:
> Âconfig=1,config1=2
>
> You can use 'perf stat' to access to the uncore pmu. For example:
> Âperf stat -a -C 0 -e 'Uncore_iMC_0/CAS_COUNT_RD/' sleep 1
> Âperf stat -a -C 0 -e 'Uncore_iMC_0/event=CAS_COUNT_RD/' sleep 1
>
> Any comment is appreciated.
> Thank you
> ---
> Changes since v1:
> Â- Modify perf tool to parse events from sysfs
> Â- A few minor code cleanup
>
> Changes since v2:
> Â- Place all events for a particular socket onto a single cpu
> Â- Make the events parser in perf tool reentrantable
> Â- A few code cleanup
>
> Changes since v3:
> Â- Use per cpu pointer to track uncore box
> Â- Rework the cpu hotplug code because topology_physical_package_id()
> Â return wrong result when the cpu is offline
> Â- Rework the event alias code, event terms are stored in the alias
> Â structure instead events string
>
> Changes since v4:
> Â- Include Jiri's uncore related changes patch set
> Â- Add pmu/event=alias/ syntax support
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/